feat(site): open dev container in vscode #17182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
863762b to
f4b6ac3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new VSCodeDevContainerButton component to open a dev container in VSCode, updates related storybook stories, and refactors existing components to pass the full agent object rather than just the agent name.
- Added the VSCodeDevContainerButton component with variant selection for VSCode and VSCode Insiders.
- Updated storybook stories for VSCodeDevContainerButton.
- Refactored AgentRow and AgentDevcontainerCard to use an agent object and updated the related prop names accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/modules/resources/VSCodeDevContainerButton/VSCodeDevContainerButton.tsx | New component for opening dev containers in VSCode with variant selection. |
| site/src/modules/resources/VSCodeDevContainerButton/VSCodeDevContainerButton.stories.tsx | Added stories for displaying the new VSCodeDevContainerButton component. |
| site/src/modules/resources/AgentRow.tsx | Updated prop from agentName to agent to match the agent object structure. |
| site/src/modules/resources/AgentDevcontainerCard.tsx | Refactored to use the agent object instead of a separate agentName prop. |
| site/src/modules/resources/AgentDevcontainerCard.stories.tsx | Updated stories to pass an agent object rather than an agent name string. |
Comments suppressed due to low confidence (2)
site/src/modules/resources/AgentRow.tsx:292
- Ensure that the receiving component and its prop types have been updated to accept the full agent object rather than just a string value. If not, update the component's prop definitions accordingly.
agent={agent}
site/src/modules/resources/AgentDevcontainerCard.tsx:61
- Verify that the TerminalLink component's prop 'agentName' is correctly expecting a string derived from agent.name after the refactoring, or update its definition if necessary.
agentName={agent.name}
f4b6ac3 to
a8d1d21
Compare
a8d1d21 to
caee9c0
Compare
mtojek
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16426
Adds a new button
VSCodeDevContainerButtonfor connecting to a dev container with VSCode.