feat: add job status filter #17202
Merged
feat: add job status filter #17202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a job status filter to the Organization Provisioner Jobs page, allowing users to filter jobs by their status. Key changes include the addition of a new status-select UI in the view component, updates in the API and query functions to handle filtering by status, and corresponding story adjustments to demonstrate the filtered state.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| OrganizationProvisionerJobsPageView.tsx | Added status filter UI using a Select component and introduced a mapping object for status indicators. |
| OrganizationProvisionerJobsPageView.stories.tsx | Added a new story with state to simulate filtering behavior using the status filter. |
| OrganizationProvisionerJobsPage.tsx | Integrated URL search parameters to drive filtering and updated query calls accordingly. |
| JobRow.tsx | Included a conditional to render template name or a placeholder if undefined. |
| CancelJobConfirmationDialog.tsx | Updated the query key call to match the new naming. |
| organizations.ts | Renamed query key and updated the query function to handle job status filtering. |
| api.ts | Modified the API method to accept an optional status parameter and build the query string appropriately. |
Comments suppressed due to low confidence (2)
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPageView.tsx:60
- [nitpick] Consider updating the 'status' property type to 'ProvisionerJobStatus' for consistency with the rest of the filtering logic.
type JobProvisionersFilter = { status: string; };
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerJobsPage/OrganizationProvisionerJobsPageView.stories.tsx:86
- The variable 'MockProvisionerJobs' is referenced but not imported; please verify whether the correct mock data variable is used or update the import accordingly.
const filteredJobs = MockProvisionerJobs.filter((job) =>
bcpeinhardt
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17155
Demo:
Screen.Recording.2025-04-01.at.16.08.45.mov