Skip to content

chore: pin dogfood npm dependencies #17216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

chore: pin dogfood npm dependencies #17216

merged 1 commit into from
Apr 2, 2025
+2 −2

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Apr 2, 2025

No description provided.

@sreya sreya requested a review from matifali April 2, 2025 07:44
matifali
matifali approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these be taken care by dependabot updates after pining? Then yes.
Otherwise it may be a bit hectic to upgrade manually.

@sreya
Copy link
Collaborator Author

sreya commented Apr 2, 2025 •
edited
Loading

@matifali why's that? It's pretty easy to get the hashes this doesn't change much about how we do things.

@matifali
Copy link
Member

matifali commented Apr 2, 2025

Just because the person needs to get the sha manually from somewhere.

@sreya
Copy link
Collaborator Author

sreya commented Apr 2, 2025

If you're updating the Dockerfile you can just do npm view pkg@version dist.integrity

@matifali
Copy link
Member

matifali commented Apr 2, 2025

Just because the person needs to get the sha manually from somewhere.

@matifali
Copy link
Member

matifali commented Apr 2, 2025 •
edited
Loading

While you are here. There are a few more you might be interested in.

Warn: containerImage not pinned by hash: examples/parameters/build/Dockerfile:1: pin your Docker image by updating ubuntu to ubuntu@sha256:72297848456d5d37d1262630108ab308d3e9ec7ed1c3286a32fe09856619a782
Warn: containerImage not pinned by hash: scripts/Dockerfile:9
Warn: containerImage not pinned by hash: scripts/Dockerfile.base:4: pin your Docker image by updating alpine:3.21.2 to alpine:3.21.2@sha256:56fa17d2a7e7f168a043a2712e63aed1f8543aeafdcee47c58dcffe38ed51099
Warn: containerImage not pinned by hash: scripts/ironbank/Dockerfile:5
Warn: goCommand not pinned by hash: dogfood/coder/Dockerfile:25-85
Warn: npmCommand not pinned by hash: dogfood/coder/Dockerfile:250
Warn: npmCommand not pinned by hash: dogfood/coder/Dockerfile:251
Warn: downloadThenRun not pinned by hash: examples/jfrog/docker/build/Dockerfile:25
Warn: goCommand not pinned by hash: .github/workflows/ci.yaml:253
Warn: goCommand not pinned by hash: .github/workflows/ci.yaml:864
Warn: downloadThenRun not pinned by hash: .github/workflows/ci.yaml:214
Warn: goCommand not pinned by hash: .github/workflows/security.yaml:100

@sreya sreya merged commit d6c034d into main Apr 2, 2025
30 checks passed
@sreya sreya deleted the jon/pinneddeps branch April 2, 2025 07:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @matifali