chore: sort agent /list-directory output
#17218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refines the output of the /list-directory agent command by sorting the contents list alphabetically with directories prioritized for an improved UX on the Coder Desktop interface.
- Updated the sorting logic in agent/ls.go to ensure directories appear first, followed by files in alphabetical order.
- Modified the test in agent/ls_internal_test.go to validate the new order using require.Equal.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agent/ls_internal_test.go | Updated test expectations to check explicit sorted output. |
| agent/ls.go | Introduced a sorting function with directories prioritized. |
deansheather
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorts the
contentslist alphabetically, but with directories before everything else.This is purely for UX on the Coder Desktop side, where the user only really cares about directories, and files are just for providing context in the file picker.