fix(cli): modify exp mcp configure to also read claude API key from CLAUDE_API_KEY env
#17229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CLAUDE_API_KEY env
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CLI configuration for Claude Code to support reading the API key from the canonical CLAUDE_API_KEY environment variable rather than only CODER_MCP_CLAUDE_API_KEY.
- Renames apiKey to claudeAPIKey and introduces a deprecated alias variable (claudeAPIKeyAlt) for backwards compatibility.
- Updates warning messages and command flag configurations to reflect the new canonical environment variable.
Comments suppressed due to low confidence (2)
cli/exp_mcp.go:144
- Consider implementing a fallback assignment where if claudeAPIKey is empty but claudeAPIKeyAlt is provided, claudeAPIKey is set to claudeAPIKeyAlt. This change would allow users to rely on the deprecated alias during the transition period.
if claudeAPIKey == "" && claudeAPIKeyAlt == "" {
cli/exp_mcp.go:114
- [nitpick] Consider renaming 'claudeAPIKeyAlt' to 'deprecatedClaudeAPIKey' to more clearly indicate that this alias is temporary and will be removed in a future version.
claudeAPIKeyAlt string
exp mcp configure to also read claude API key from CLAUDE_API_KEY env
hugodutka
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you have to set
CODER_MCP_CLAUDE_API_KEY, which can be obnoxious.