refactor: update avatar sizes in groups, users and members #17230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors avatar sizes across several pages to use the "lg" size, ensuring consistency in avatar presentation.
- Updates avatar size props to "lg" in Users, Groups, and Members pages
- Refactors layout for group member avatars in GroupsPageView by replacing AvatarGroup with a custom layout
- Adjusts table and skeleton components for improved padding and sizing consistency
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/pages/UsersPage/UsersTable/UsersTableBody.tsx | Removed a flex container wrapping an avatar skeleton |
| site/src/pages/OrganizationSettingsPage/OrganizationMembersPageView.tsx | Updated avatar size and added conditional rendering for loading state |
| site/src/pages/GroupsPage/GroupsPageView.tsx | Replaced AvatarGroup with a custom flex layout including a Badge for extra members |
| site/src/pages/GroupsPage/GroupPage.tsx | Updated avatar size in the member row |
| site/src/components/Table/Table.tsx | Modified padding classes in table head and cells |
| site/src/components/LastSeen/LastSeen.tsx | Updated to include utility classes for whitespace handling |
| site/src/components/Avatar/AvatarDataSkeleton.tsx | Added a shrink-0 class to the skeleton for layout control |
| site/src/components/Avatar/AvatarData.tsx | Updated to default to avatar size "lg" and added a color class to the title span |
| site/src/components/Avatar/Avatar.tsx | Replaced explicit height/width classes with shorthand utility classes for avatar sizing |
Parkreiner
approved these changes
Apr 2, 2025
aqandrew
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the template and workspace avatars to be "lg" so to keep it consistent we have to do the same for the other avatars too.