fix: prevent invalid render output for build logs #17233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue to link – fixing this because it was making it harder to diagnose some of the potential problems with our switch over to One-Way Web Sockets in the UI. There were too many extra errors being logged to the console
Changes made
Line
type inLogLine.tsx
to support an ID value to prevent key conflicts during React rendering. Also deleted theLineWithID
type, which became redundant after the changeLogs
component to use the ID to avoid render key conflictsNotes
console.error
calls that React will automatically spit out, so this should help us a good bit in the future