feat: create experimental CreateWorkspacePage and dynamic-parameters experiment #17240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an experimental workspace creation page and enables a dynamic-parameters experiment mode. Key changes include:
- Routing update in site/src/router.tsx to use an experimental router component.
- Creation of a new experimental workspace page (CreateWorkspacePageExperimental) with enhanced dynamic parameter and auto-create logic.
- Updates to experiment flags and documentation across API, deployment, and apidoc files.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/router.tsx | Updates the route to reference the experimental workspace creation router. |
| site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx | Adds a new experimental workspace creation flow with dynamic parameters and auto-creation logic. |
| site/src/pages/CreateWorkspacePage/CreateWorkspaceExperimentRouter.tsx | Routes to the experimental or standard workspace page based on the dynamic-parameters flag. |
| site/src/api/typesGenerated.ts | Registers the new "dynamic-parameters" experiment. |
| docs/reference/api/schemas.md | Documents the new "dynamic-parameters" experiment. |
| codersdk/deployment.go | Introduces the dynamic parameters experiment flag in deployment settings. |
| coderd/apidoc/docs.go | Updates API documentation to include the dynamic parameters experiment. |
Files not reviewed (1)
- coderd/apidoc/swagger.json: Language not supported
Comments suppressed due to low confidence (2)
site/src/pages/CreateWorkspacePage/CreateWorkspaceExperimentRouter.tsx:3
- [nitpick] Consider aligning naming conventions between CreateWorkspacePageExperimental and CreateWorkspaceExperimentRouter for consistency, such as using 'Experimental' in both component names.
import CreateWorkspacePage from "./CreateWorkspacePage";
site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx:122
- Consider adding tests to cover the automatic workspace creation logic and dynamic parameter processing to ensure correct behavior under various scenarios.
const automateWorkspaceCreation = useEffectEvent(async () => {
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the PR is to make a copy of the CreateWorkspacePage and create an experimental version that will use when the dynamic-parameters experiment is enabled.
The Figma designs for this page are still in progress but this first PR will start to move to the new designs.
Figma design: https://www.figma.com/design/SMg6H8VKXnPSkE6h9KPoAD/UX-Presets?node-id=2121-2383&t=CtgPUz8eNsTI5b1t-1
Much of the existing code will be left behind and will slowly migrated over the course of several PRs to make sure no existing functionality is forgotten in the migration to dynamic paramaters.