Skip to content

feat: extend request logs with auth & DB info #17304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 15, 2025
+336 −35
Merged

feat: extend request logs with auth & DB info #17304

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1239656
extended the user query to include email and added a handler for logger
ibetitsmike Apr 9, 2025
39f124c
removed Type from compare
ibetitsmike Apr 10, 2025
a8b8b96
protected user map on request with mutex
ibetitsmike Apr 10, 2025
876a0d1
fixing missing closing quote
ibetitsmike Apr 10, 2025
d1ee48e
added logging for workspace related parameters and generic chi contex…
ibetitsmike Apr 11, 2025
8ef5646
added comment for chi ctx extraction
ibetitsmike Apr 11, 2025
6567965
added tests for logging handler
ibetitsmike Apr 14, 2025
4ecaf83
added a 'params_' prefix
ibetitsmike Apr 15, 2025
c60cabc
added ordering of subjecttypes on logging the actor
ibetitsmike Apr 15, 2025
9ddfd2d
changed ordering of actors in logs
ibetitsmike Apr 15, 2025
9146744
updated comments
ibetitsmike Apr 15, 2025
bd5104c
changed field ordering
ibetitsmike Apr 15, 2025
28dee4b
lint fixes
ibetitsmike Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added comment for chi ctx extraction
  • Loading branch information
@ibetitsmike
ibetitsmike committed Apr 14, 2025
commit 8ef56461165eb68835896cde7b0aa13d783ea26f
1 change: 1 addition & 0 deletions coderd/httpmw/loggermw/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ func (c *SlogRequestLogger) WriteLog(ctx context.Context, status int) {
slog.F("latency_ms", float64(end.Sub(c.start)/time.Millisecond)),
)

// If the request is routed, add the route parameters to the log.
if chiCtx := chi.RouteContext(ctx); chiCtx != nil {
urlParams := chiCtx.URLParams
routeParamsFields := make([]slog.Field, 0, len(urlParams.Keys))
Expand Down
Loading