feat(coderd/notifications): group workspace build failure report #17306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sending X many reports to a single template admin, we instead send only 1.
There was a problem hiding this comment.
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (3)
- coderd/database/migrations/000316_group_build_failure_notifications.up.sql: Language not supported
- coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceBuildsFailedReport.html.golden: Language not supported
- coderd/notifications/testdata/rendered-templates/webhook/TemplateWorkspaceBuildsFailedReport.json.golden: Language not supported
Comments suppressed due to low confidence (1)
coderd/notifications/notifications_test.go:1014
- The key 'template_version_count' appears inconsistent with similar keys such as 'template_version_name'. Consider renaming it for consistency.
"template_version_count": "bobby-template-version-2",
The CTA should link to a list of every affected workspace
mtojek
reviewed
Apr 10, 2025
coderd/database/migrations/000316_group_build_failure_notifications.up.sql
Show resolved
Hide resolved
coderd/database/migrations/000316_group_build_failure_notifications.up.sql
Show resolved
Hide resolved
|
/cherry-pick release/2.21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15745
Instead of sending X many reports to a single template admin, we instead send only 1.