Skip to content

feat(agent): implement recreate for devcontainers #17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 10, 2025
Merged

feat(agent): implement recreate for devcontainers #17308

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6d18522
feat(agent): implement recreate for devcontainers
mafredri Apr 9, 2025
6b08fd1
remove ai comments from test
mafredri Apr 9, 2025
db6157e
update comments
mafredri Apr 9, 2025
c214476
oopsie
mafredri Apr 9, 2025
486bb3f
consistent var naming
mafredri Apr 9, 2025
379b262
restructure test
mafredri Apr 9, 2025
ca791d6
wait medium just in case
mafredri Apr 9, 2025
2692e55
mark testdata as generated
mafredri Apr 9, 2025
2687bfd
allow paralleltest
mafredri Apr 10, 2025
b850b07
rename log writer
mafredri Apr 10, 2025
6b8ad8c
fixup! allow paralleltest
mafredri Apr 10, 2025
1d937a0
fixup! fixup! allow paralleltest
mafredri Apr 10, 2025
f5e2328
fixup! fixup! fixup! allow paralleltest
mafredri Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! allow paralleltest
  • Loading branch information
@mafredri
mafredri committed Apr 10, 2025
commit 6b8ad8c2373dd180e98e98d896b74bcd57dfed2e
1 change: 0 additions & 1 deletion agent/agentcontainers/devcontainercli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ func TestDevcontainerCLI_ArgsAndParsing(t *testing.T) {

logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug)

//nolint:paralleltest // This test is not parallel-safe due to t.Setenv.
t.Run("Up", func(t *testing.T) {
tests := []struct {
name string
Expand Down
Loading