Skip to content

fix(agent): fix deadlock if closed while starting listeners #17329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix(agent): fix deadlock if closed while starting listeners #17329

merged 1 commit into from
Apr 10, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 10, 2025 •
edited
Loading

fixes #17328

Fixes a deadlock if we close the Agent in the middle of starting listeners on the tailnet.

@spikecurtis Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested a review from mafredri April 10, 2025 08:16
@spikecurtis spikecurtis marked this pull request as ready for review April 10, 2025 08:16
mafredri
mafredri approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Apr 10, 2025 •
edited
Loading

Merge activity

  • Apr 10, 4:46 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 4:46 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit c1816e3 into main Apr 10, 2025
41 checks passed
@spikecurtis spikecurtis deleted the spike/agent-close-while-starting branch April 10, 2025 08:46
johnstcn pushed a commit that referenced this pull request Apr 10, 2025
@spikecurtis @johnstcn
fix(agent): fix deadlock if closed while starting listeners (#17329)
cfd0b2b 
fixes #17328

Fixes a deadlock if we close the Agent in the middle of starting listeners on the tailnet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Agent can deadlock if closed while creating tailnet listeners
2 participants
@spikecurtis @mafredri