Skip to content

refactor(agent/agentcontainers): implement API service #17340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

refactor(agent/agentcontainers): implement API service #17340

merged 2 commits into from
Apr 11, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Apr 10, 2025 •
edited
Loading

This refactor improves separation of API and containers with minimal changes to logic.

Not a lot of code was changed, so here are the highlights:

  • Routes are now defined in agentcontainers package
  • Handler renamed to API
  • API lazy init was moved into NewAPI
  • Tests that don't need to be internal were made external

@mafredri mafredri requested a review from Copilot April 10, 2025 14:57
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

@mafredri mafredri changed the title refactor(agent/agentcontainers): Implement API service refactor(agent/agentcontainers): implement API service Apr 10, 2025
@mafredri mafredri force-pushed the mafredri/feat-agent-recreate-devcontainer-refactor branch from 2b7316b to 31c7bff Compare April 10, 2025 15:05
@mafredri mafredri marked this pull request as ready for review April 10, 2025 15:16
johnstcn
johnstcn reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will approve once tests run 👍 (EDIT: looks like they did previously)

@mafredri mafredri merged commit 60fbe67 into main Apr 11, 2025
34 checks passed
@mafredri mafredri deleted the mafredri/feat-agent-recreate-devcontainer-refactor branch April 11, 2025 08:41
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@johnstcn johnstcn johnstcn approved these changes

@DanielleMaywood DanielleMaywood Awaiting requested review from DanielleMaywood

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @johnstcn