Skip to content

feat: add edit-role within user command #17341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brettkolodny
Copy link
Contributor

@brettkolodny brettkolodny commented Apr 10, 2025

Closes coder/internal #207

CleanShot.2025-04-11.at.14.30.24.mp4

@brettkolodny brettkolodny marked this pull request as draft April 10, 2025 15:01
@brettkolodny brettkolodny marked this pull request as ready for review April 10, 2025 15:13
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me, this sounds like it would edit their site-wide roles, not organization scoped roles. also, single organization deployments actually can't assign org-scoped roles. 🤔

I think the wording in the original ticket was a bit misleading/misguided. this shouldn't be an alias, it should be a new command that edits site wide roles.

@brettkolodny
Copy link
Contributor Author

Ah gotcha, thank you for the clarification!

@brettkolodny brettkolodny changed the title feat: alias the organization edit-role command within the user command feat: add edit-role within user command Apr 11, 2025
@brettkolodny brettkolodny requested a review from aslilac April 11, 2025 18:25
@brettkolodny
Copy link
Contributor Author

Implemented a new edit-roles command as suggested

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but needs tests!

@brettkolodny brettkolodny requested a review from aslilac April 15, 2025 20:51
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks!

@brettkolodny brettkolodny merged commit 70b113d into main Apr 15, 2025
36 checks passed
@brettkolodny brettkolodny deleted the brett-i207/add-coder-user-edit-role-command-for-edit branch April 15, 2025 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coder user edit-role command for editing user roles in CLI
2 participants