Skip to content

feat(testutil): add GetRandomNameHyphenated #17342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

feat(testutil): add GetRandomNameHyphenated #17342

merged 3 commits into from
Apr 10, 2025

Conversation

johnstcn
Copy link
Member

This started coming up more often for me, so time for a test helper!

@johnstcn johnstcn added the hotfix PRs only. Harmless small change. Only humans may set this. label Apr 10, 2025
@johnstcn johnstcn requested a review from Copilot April 10, 2025 16:46
@johnstcn johnstcn self-assigned this Apr 10, 2025
cdr-bot[bot]
cdr-bot bot approved these changes Apr 10, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@johnstcn @Copilot
Update testutil/names.go
512a26c 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
johnstcn
johnstcn commented Apr 10, 2025
View reviewed changes
@johnstcn
Update testutil/names.go
371476a 
no need to double-inc
@johnstcn johnstcn merged commit 1e0051a into main Apr 10, 2025
34 checks passed
@johnstcn johnstcn deleted the cj/testutil/GetRandomNameHyphenated branch April 10, 2025 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@johnstcn johnstcn

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn