Skip to content

chore!: remove JFrog integration #17353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

chore!: remove JFrog integration #17353

merged 2 commits into from
Apr 11, 2025

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Apr 11, 2025

Removes displaying XRay scan results in the dashboard. I'm not sure anyone was even using this integration so it's just debt for us to maintain. We can open up a separate issue to get rid of the db tables once we know for sure that we haven't broken anyone.

@sreya sreya requested a review from spikecurtis April 11, 2025 03:03
@spikecurtis spikecurtis changed the title chore: remove JFrog integration chore!: remove JFrog integration Apr 11, 2025
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Apr 11, 2025
Copy link
Contributor

Technically breaking, so I changed to chore!.

How can we gain confidence that no paying customers are using this feature?

Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to be rebased to fix the CI errors, but LGTM

@sreya
Copy link
Collaborator Author

sreya commented Apr 11, 2025

How can we gain confidence that no paying customers are using this feature?

Going to lead on product for this.

@sreya sreya merged commit c06ef7c into main Apr 11, 2025
37 of 39 checks passed
@sreya sreya deleted the jon/rmjfrog branch April 11, 2025 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants