Skip to content

feat(docs): add Vale style checking and docs workflow improvements #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Apr 11, 2025

relies on

Summary

  • Add Vale style checking for technical documentation
  • Create unified docs workflows and actions in .github/docs
  • Improve preview links and automated checks for documentation changes

Test plan

  1. Check that new Vale styles correctly detect common documentation errors
  2. Verify docs preview links are generated correctly in PR comments
  3. Ensure documentation actions run consistently for Markdown files

🤖 Generated with Claude Code

EdwardAngert and others added 10 commits April 9, 2025 18:26
Creates a simplified docs preview action that comments on PRs with Vercel preview links.
The action shows changed files and highlights newly added documentation from manifest.json.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
…o use the same SHA and version (v45.0.7) that the docs-ci.yaml workflow uses.\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.ai/code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>\
…d to match patterns from the successful pr-deploy.yaml workflow:\n- Added job-level pull-requests write permission\n- Added explicit env var for PR_NUMBER\n- Added explicit GITHUB_TOKEN environment variable\n- Added reactions-edit-mode for consistency\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.ai/code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>\
Create a unified composite action for docs-related workflows:
- Handles file change detection with tj-actions/changed-files
- Provides linting and formatting for markdown files
- Generates preview links for documentation changes
- Creates or updates PR comments with preview links
- Includes special handling for manifest.json changes
- Implements security best practices
- Provides example workflow
- Add Vale style checking for documentation
- Move all docs-related GitHub actions & config to centralized .github/docs directory
- Consolidate docs validation in unified workflow
- Update all workflows to reference new paths
- Add customizable docs terminology rules
…style

- Add readability checks with appropriate thresholds
- Allow informal terms like 'K8s', 'dev container', 'AWS EC2' common in docs
- Add technical terminology exceptions to heading case rules
- Balance formal style with pragmatic documentation practices
@EdwardAngert EdwardAngert marked this pull request as draft April 11, 2025 21:34
Copy link

📚 Docs Preview

Your documentation changes are available for preview at:
🔗 Documentation Preview

Changed Documentation Files


🤖 This comment is automatically generated and updated when documentation changes.

@EdwardAngert EdwardAngert added the docs/site docs site-related issue/task/feature request label Apr 11, 2025
@github-actions github-actions bot added the stale This issue is like stale bread. label Apr 19, 2025
@EdwardAngert EdwardAngert removed the stale This issue is like stale bread. label Apr 21, 2025
EdwardAngert added a commit that referenced this pull request Apr 23, 2025
Combines features from PRs #17317, #17322, and #17370:
- Adds Vale style checking for documentation
- Creates a reusable workflow for documentation validation
- Optimizes PR checks and post-merge validation
- Adds automatic GitHub issue creation for broken links
- Updates all documentation checks to run in a structured manner

This PR supersedes:
- PR #17317: Docs Preview GitHub Action
- PR #17322: Shared Docs GitHub Action
- PR #17370: Vale Style Checking and Docs Workflow Improvements
@EdwardAngert
Copy link
Contributor Author

replaced by #17522

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs/site docs site-related issue/task/feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant