feat: setup connection to dynamic parameters websocket #17393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
Apr 15, 2025
site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
Outdated
Show resolved
Hide resolved
a39b095 to
e04ce2f
Compare
266620a to
440fedc
Compare
aslilac
approved these changes
Apr 16, 2025
Comment on lines
113
to
125
| const sendMessage = (formValues: Record<string, string>) => { | ||
| setWSResponseId((prevId) => { | ||
| const request: DynamicParametersRequest = { | ||
| id: prevId + 1, | ||
| inputs: formValues, | ||
| }; | ||
| if (ws.current && ws.current.readyState === WebSocket.OPEN) { | ||
| ws.current.send(JSON.stringify(request)); | ||
| return prevId + 1; | ||
| } | ||
| return prevId; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
one last thought, I noticed that onMessage is wrapped in a useCallback but this isn't. was that intentional? could be nice to wrap this one as well since it's also being passed as a prop to a child 🤷♀️
There was a problem hiding this comment.
onMessage was wrapped because its used as a dependency for a useEffect. Sure I can wrap sendMessage as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves coder/preview#57