Skip to content

refactor: update the workspace table design #17404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #17309

Before:
Screenshot 2025-04-15 at 11 36 32

After:
Screenshot 2025-04-15 at 11 36 22

@BrunoQuaresma BrunoQuaresma requested review from a team and aslilac and removed request for a team April 15, 2025 14:39
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 15, 2025
Name
</div>
</TableHead>
{hasAppStatus && <TableHead className="w-[30%]">Activity</TableHead>}
Copy link
Contributor

@jaaydenh jaaydenh Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to handle the column widths is like this
<TableHead className="w-2/5">IdP organization</TableHead> <TableHead className="w-3/5">Coder organization</TableHead> <TableHead className="w-auto" />

@jaaydenh
Copy link
Contributor

@BrunoQuaresma Are you planning on updating the row height in a separate PR? I noticed in the new design the row height is 72px but currently it is 64px

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. just a few small comments.

@aslilac
Copy link
Member

aslilac commented Apr 15, 2025

why is the border on the top row thicker in the screenshot?

@BrunoQuaresma
Copy link
Collaborator Author

@aslilac @jaaydenh good catches! Fixing them right now.

@jaaydenh
Copy link
Contributor

why is the border on the top row thicker in the screenshot?

This is the new row hover design.

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Apr 15, 2025

why is the border on the top row thicker in the screenshot?

This is the new row hover design.

But the offset width was wrong (@aslilac has an awesome robotic eye). Since we are not using the TailwindCSS preflight, I had to use the outline-1 because it was not set by default.

@BrunoQuaresma BrunoQuaresma merged commit b0fe626 into main Apr 15, 2025
34 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-ws-tables branch April 15, 2025 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants