feat: add slider component #17431
Merged
feat: add slider component #17431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Apr 16, 2025
Comment on lines
16
to
19
| className={cn( | ||
| "relative flex w-full touch-none select-none items-center h-1.5", | ||
| className, | ||
| )} |
There was a problem hiding this comment.
Do we want to split this off into three values, since two of the classes are actually behavioral and not just stylistic? I don't see a case where we would ever want those to be overridden
className={cn(
"relative flex w-full items-center h-1.5",
className,
"touch-none select-none",
)}I'd rather make a bad UX edge case impossible out of the gate, over optimizing for a use case that might not ever exist
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slider component is part of the components supported by Dynamic Parameters
There are no Figma designs for the slider component. This is based on the shadcn slider.