Skip to content

test: fix flake in TestRoleSyncTable with test cases sharing resources #17441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 16, 2025

The test case definition shares maps that can have concurrent access if run in parallel. This fixes that
Flake: https://github.com/coder/coder/actions/runs/14504014498/job/40689907014?pr=17439

The test case definition shares maps that can have concurrent access
if run in parallel. This fixes that
@Emyrk Emyrk added the hotfix PRs only. Harmless small change. Only humans may set this. label Apr 16, 2025
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Emyrk Emyrk enabled auto-merge (squash) April 16, 2025 23:18
@Emyrk Emyrk merged commit 0bc49ff into main Apr 17, 2025
40 checks passed
@Emyrk Emyrk deleted the stevenmasley/race_flake branch April 17, 2025 00:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant