chore(coderd/notifications/notificationstest): enqueue messages in FakeEnqueuer #17449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes part of the way towards #15481
We now insert notification messages in
FakeEnqueuerwhich should still have the desired effect of testing RBAC while also exercising these code paths in the rest of our tests.As part of #17412 I'll want to be testing that pubsub notifications are actually sent, and this should ensure that the code path gets hit.
Longer-term, I'd like to phase out
FakeEnqueuerentirely, but this would require all of the below tests to be rewritten.Right now this doesn't work with dbmem due to a re-entrant lock when attempting to call
EnqueueNotificationMessage().