fix: update dynamic params styles #17489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaaydenh
commented
Apr 21, 2025
•
- increase form width and adjust form field width new "create workspace" form feels too skinny #17471
- Move slider value display as its currently broken for long parameter titles and descriptions
- increase the height of the slider
- automatically increase the height of the textarea as the user types parameters: auto expand textarea when typing #17472
cbe052e to
69a9e03
Compare
aslilac
approved these changes
Apr 21, 2025
Comment on lines
320
to
324
| onInput={(e) => { | ||
| const target = e.currentTarget; | ||
| target.style.height = "auto"; | ||
| target.style.height = `${target.scrollHeight}px`; | ||
| }} |
There was a problem hiding this comment.
we probably need a max height to go with this
There was a problem hiding this comment.
and a max width too..
site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.