Skip to content

chore: revert dynamic params as a safe experiment #17510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

chore: revert dynamic params as a safe experiment #17510

merged 2 commits into from
Apr 22, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 22, 2025

No description provided.

@Emyrk Emyrk added the hotfix PRs only. Harmless small change. Only humans may set this. label Apr 22, 2025
cdr-bot[bot]
cdr-bot bot previously approved these changes Apr 22, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main or release branch
  • ❌ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Emyrk Emyrk removed the hotfix PRs only. Harmless small change. Only humans may set this. label Apr 22, 2025
@cdr-bot cdr-bot bot dismissed their stale review April 22, 2025 15:28

This PR is no longer a hotfix.

@Emyrk Emyrk requested review from aslilac and jaaydenh April 22, 2025 15:30
jaaydenh
jaaydenh approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe is a much better name

@Emyrk Emyrk enabled auto-merge (squash) April 22, 2025 15:35
johnstcn
johnstcn approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@Emyrk Emyrk merged commit ca38729 into main Apr 22, 2025
36 checks passed
@Emyrk Emyrk deleted the stevenmasley/safe_exp branch April 22, 2025 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
aslilac
aslilac reviewed Apr 22, 2025
View reviewed changes
codersdk/deployment.go
var ExperimentsAll = Experiments{
ExperimentDynamicParameters,
}
var ExperimentsSafe = Experiments{}
Copy link
Member

@aslilac aslilac Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is such a good and necessary rename. thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac left review comments

@jaaydenh jaaydenh jaaydenh approved these changes

@johnstcn johnstcn johnstcn approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] left review comments

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Emyrk @aslilac @jaaydenh @johnstcn