Skip to content

fix: don't show promote button for members (cherry-pick #17511) #17513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

fix: don't show promote button for members (cherry-pick #17511) #17513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec201b
fix: don't show promote button for members (#17511)
BrunoQuaresma Apr 22, 2025
35af566
Merge branch 'release/2.21' into cherry-pick-41726c-release/2.21
matifali Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export const VersionRow: FC<VersionRowProps> = ({
});

const jobStatus = version.job.status;
const showActions = onPromoteClick || onArchiveClick;

return (
<TimelineEntry
Expand Down Expand Up @@ -106,7 +105,7 @@ export const VersionRow: FC<VersionRowProps> = ({
</Pill>
)}

{showActions && jobStatus === "failed" ? (
{jobStatus === "failed" && onArchiveClick && (
<Button
css={styles.promoteButton}
disabled={isActive || version.archived}
Expand All @@ -118,7 +117,9 @@ export const VersionRow: FC<VersionRowProps> = ({
>
Archive&hellip;
</Button>
) : (
)}

{jobStatus === "succeeded" && onPromoteClick && (
<Button
css={styles.promoteButton}
disabled={isActive || jobStatus !== "succeeded"}
Expand Down
Loading