feat: add prebuilds metrics collector #17547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2431bbe to
45a0672
Compare
SasSwart
reviewed
Apr 24, 2025
45a0672 to
80fba7d
Compare
mafredri
reviewed
Apr 24, 2025
8c3e53e to
9676b65
Compare
a69ee41 to
7791f50
Compare
d43c13d to
00ebdde
Compare
Signed-off-by: Danny Kopping <dannykopping@gmail.com> Reverting unnecessary changes that crept in Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
00ebdde to
1d66ade
Compare
mafredri
approved these changes
Apr 28, 2025
| {"coderd_prebuilt_workspaces_eligible", ptr.To(0.0), false}, | ||
| }, | ||
| templateDeleted: []bool{false}, | ||
| eligible: []bool{false}, |
There was a problem hiding this comment.
I'm not seeing any test-cases where we'd need slices for deleted/eligible and it probably isn't too compatible with the way expected metrics are defined. Consider simplifying (helps reduce complexity of test body too)?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#509