feat: RBAC provisionerdaemons and parameters #1755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
May 25, 2022
coderd/coderd.go
Outdated
Comment on lines
145
to
151
| r.Route("/provisionerdaemons", func(r chi.Router) { | ||
| r.Use( | ||
| apiKeyMiddleware, | ||
| authRolesMiddleware, | ||
| ) | ||
| r.Get("/", a.provisionerDaemons) | ||
| }) |
There was a problem hiding this comment.
Moved out of the org subroutes.
coderd/parameters.go
Outdated
Comment on lines
87
to
91
| // Should we allow reading the params of the resource if they can read the | ||
| // resource? Will this leak secrets? | ||
| if !api.Authorize(rw, r, rbac.ActionRead, obj) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Should we allow reading the params of the resource if they can read the resource? Will this leak secrets?
Comment on lines
+226
to
+230
| case database.ParameterScopeImportJob: | ||
| // This scope does not make sense from this api. | ||
| // ImportJob params are created with the job, and the job id cannot | ||
| // be predicted. | ||
| err = xerrors.Errorf("ImportJob scope not supported") |
There was a problem hiding this comment.
I don't think this makes sense from this API. This api sets params associated with a resource, but a job is very short lived. It doesn't make sense to set this scope like this. Right?
coderd/parameters.go
Outdated
| // is equivalent to updating/reading the associated resource. | ||
| // This means "parameters" are not a new resource, but an extension of existing | ||
| // ones. | ||
| func (api *api) parameterRBACResource(rw http.ResponseWriter, r *http.Request, scope database.ParameterScope, scopeID uuid.UUID) (rbac.Objecter, bool) { |
There was a problem hiding this comment.
Setting params for a resource that does not exist will now 403 forbidden.
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* chore: Remove org_id from provisionerdaemons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters
When setting a parameter for a scope, that underlying resource must exist. The RBAC check is to
updatethe underlying resource.