Skip to content

fix: display validation error for workspace name #17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

fix: display validation error for workspace name #17564

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08e54f3
fix: display validation error for workspace name
jaaydenh Apr 24, 2025
bcd9050
fix: use ref for workspace name input
jaaydenh Apr 30, 2025
dd76a3a
fix: format
jaaydenh Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
useContext,
useEffect,
useId,
useRef,
useState,
} from "react";
import { getFormHelpers, nameValidator } from "utils/formUtils";
Expand Down Expand Up @@ -103,6 +104,7 @@ export const CreateWorkspacePageViewExperimental: FC<
);
const [showPresetParameters, setShowPresetParameters] = useState(false);
const id = useId();
const workspaceNameInputRef = useRef<HTMLInputElement>(null);
const rerollSuggestedName = useCallback(() => {
setSuggestedName(() => generateWorkspaceName());
}, []);
Expand Down Expand Up @@ -140,10 +142,15 @@ export const CreateWorkspacePageViewExperimental: FC<
}
}, [error]);

const getFieldHelpers = getFormHelpers<TypesGen.CreateWorkspaceRequest>(
form,
error,
);
useEffect(() => {
if (form.submitCount > 0 && form.errors) {
workspaceNameInputRef.current?.scrollIntoView({
behavior: "smooth",
block: "center",
});
workspaceNameInputRef.current?.focus();
}
}, [form.submitCount, form.errors]);

const [presetOptions, setPresetOptions] = useState([
{ label: "None", value: "" },
Expand Down Expand Up @@ -333,16 +340,22 @@ export const CreateWorkspacePageViewExperimental: FC<
<Label className="text-sm" htmlFor={`${id}-workspace-name`}>
Workspace name
</Label>
<div>
<div className="flex flex-col">
<Input
id={`${id}-workspace-name`}
ref={workspaceNameInputRef}
value={form.values.name}
onChange={(e) => {
form.setFieldValue("name", e.target.value.trim());
resetMutation();
}}
disabled={creatingWorkspace}
/>
{form.touched.name && form.errors.name && (
<div className="text-content-destructive text-xs mt-2">
{form.errors.name}
</div>
)}
<div className="flex gap-2 text-xs text-content-secondary items-center">
Need a suggestion?
<Button
Expand Down Expand Up @@ -477,7 +490,6 @@ export const CreateWorkspacePageViewExperimental: FC<

return (
<DynamicParameter
{...getFieldHelpers(parameterInputName)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not using the MUI TextField, this is not necessary

key={parameter.name}
parameter={parameter}
onChange={(value) =>
Expand Down
Loading