Skip to content

WIP! feat: log resource replacements when claiming a prebuilt workspace #17571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP! feat: log resource replacements when claiming a prebuilt workspace #17571

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3344cff
fix: pass store to claimer
dannykopping Apr 25, 2025
afbc680
feat: log resource replacements
dannykopping Apr 25, 2025
fa86df4
feat: show terraform state drift diff in build logs
dannykopping Apr 25, 2025
c7c0c4b
feat: only highlight lines which mention replacement
dannykopping Apr 25, 2025
ac6a162
feat: notify template admins when prebuild claim results in resource …
dannykopping Apr 25, 2025
148c1d7
chore: appease linter
dannykopping Apr 25, 2025
08e6dee
chore: fix notifications test
dannykopping Apr 25, 2025
ca46d08
fix: don't panic
dannykopping Apr 28, 2025
64f78a2
fix: renaming type
dannykopping Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: appease linter 
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
  • Loading branch information
@dannykopping
dannykopping committed Apr 25, 2025
commit 148c1d73a6f0e2d31372a469f2dc9a5a76039cd5
8 changes: 6 additions & 2 deletions ...r/terraform/resource_replacements_test.go → ...rm/resource_replacements_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
)

func TestFindResourceReplacements(t *testing.T) {
t.Parallel()

cases := []struct {
name string
plan *tfjson.Plan
Expand All @@ -17,8 +19,8 @@ func TestFindResourceReplacements(t *testing.T) {
name: "nil plan",
},
{
name: "no resource changes",
plan: &tfjson.Plan{},
name: "no resource changes",
plan: &tfjson.Plan{},
},
{
name: "resource change with nil change",
Expand Down Expand Up @@ -166,6 +168,8 @@ func TestFindResourceReplacements(t *testing.T) {

for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()

require.EqualValues(t, tc.expected, findResourceReplacements(tc.plan))
})
}
Expand Down
Loading