-
Notifications
You must be signed in to change notification settings - Fork 874
feat(agent/agentcontainers): add file watcher and dirty status #17573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+909
−47
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
40c8de9
feat(agent/agentcontainers): add file watcher and dirty status
mafredri a997f82
make gen
mafredri 0e568fb
fix copilot nits
mafredri 4f788d9
log event string in case not write
mafredri bfeb1da
fix chmod on macos
mafredri 45a978c
fix close of closed channel
mafredri d2721a7
add close protection to fsnotify watcher as well
mafredri c03bb7d
fix typo
mafredri aed7c30
fix pr suggestions and improve start loop
mafredri 39526e6
update noop impl.
mafredri 7edee90
s/file/path
mafredri 9cf5415
rewrite watcher impl. to watch dirs
mafredri de2a42e
add rename and create to fsnotify test
mafredri 0cbee38
add atomic file replacement
mafredri 5ced7e1
add paranoid reset
mafredri 5a96a55
fix oopsie
mafredri 0b16448
s/ErrWatcherClosed/ErrClosed/g
mafredri eaf5922
inverse continue/return for clarity
mafredri 617fed2
better close handling
mafredri 8ee9914
restore removed comment
mafredri 263c683
add note about name
mafredri 58a70e8
fix test setup/clock advancement
mafredri 9f739ca
outdent
mafredri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: This change allows all
r.Context
s to inherit the graceful context from the agent, ensuring cancellation on agent shutdown.