Skip to content

fix: fix prebuild omissions #17579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

fix: fix prebuild omissions #17579

merged 2 commits into from
Apr 30, 2025

Conversation

dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Apr 28, 2025 •
edited
Loading

0a3e9a9 was an accidental omission from #17527

@dannykopping dannykopping requested a review from SasSwart April 28, 2025 12:40
@dannykopping dannykopping changed the title fix: address prebuild omissions fix: fix prebuild omissions Apr 28, 2025
@dannykopping
Copy link
Contributor Author

I hate grammar-bot.

evgeniy-scherbina
evgeniy-scherbina approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@evgeniy-scherbina evgeniy-scherbina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we may consider to add test where we add/delete prebuild user to/from a group

@dannykopping
chore: fix reconciler init
0272154 
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykopping
Copy link
Contributor Author

LGTM, but we may consider to add test where we add/delete prebuild user to/from a group

Good point; I'm gonna split that out into its own PR.

@dannykopping
fix: test
0dbe16b 
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykopping dannykopping marked this pull request as ready for review April 30, 2025 14:16
@dannykopping dannykopping enabled auto-merge (squash) April 30, 2025 14:17
@dannykopping dannykopping merged commit 6936a7b into main Apr 30, 2025
33 checks passed
@dannykopping dannykopping deleted the dk/prebuilds-hotfix branch April 30, 2025 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evgeniy-scherbina evgeniy-scherbina evgeniy-scherbina approved these changes

@SasSwart SasSwart Awaiting requested review from SasSwart

Assignees

@dannykopping dannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannykopping @evgeniy-scherbina