Skip to content

test: do not run memory race test in parallel #17582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

test: do not run memory race test in parallel #17582

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac7399a
test: do not run memory race test in parallel
Emyrk Apr 28, 2025
cd90dff
remove some parallel tests
Emyrk Apr 28, 2025
00fff8c
fmt
Emyrk Apr 28, 2025
48678b6
linting
Emyrk Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove some parallel tests
  • Loading branch information
@Emyrk
Emyrk committed Apr 28, 2025
commit cd90dff574ff661b5f75ac7c6b51c99c5247b32e
7 changes: 5 additions & 2 deletions coderd/idpsync/group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
})
}

func TestGroupSyncTable(t *testing.T) {

Check failure on line 68 in coderd/idpsync/group_test.go

View workflow job for this annotation

GitHub Actions / lint 

TestGroupSyncTable's subtests should call t.Parallel (tparallel)
t.Parallel()

// Last checked, takes 30s with postgres on a fast machine.
Expand Down Expand Up @@ -246,10 +246,13 @@
},
}

for _, tc := range testCases {

Check failure on line 249 in coderd/idpsync/group_test.go

View workflow job for this annotation

GitHub Actions / lint 

Range statement for test TestGroupSyncTable missing the call to method parallel in test Run (paralleltest)
tc := tc
// The final test, "AllTogether", cannot run in parallel.
// These tests are nearly instant using the memory db, so
// this is still fast without being in parallel.
//nolint:paralleltest, tparallel
t.Run(tc.Name, func(t *testing.T) {

Check failure on line 255 in coderd/idpsync/group_test.go

View workflow job for this annotation

GitHub Actions / lint 

empty-lines: extra empty line at the start of a block (revive)
t.Parallel()

db, _ := dbtestutil.NewDB(t)
manager := runtimeconfig.NewManager()
Expand Down Expand Up @@ -289,8 +292,8 @@
// deployment. This tests all organizations being synced together.
// The reason we do them individually, is that it is much easier to
// debug a single test case.
//nolint:paralleltest, tparallel // This should run after all the individual tests
t.Run("AllTogether", func(t *testing.T) {

Check failure on line 296 in coderd/idpsync/group_test.go

View workflow job for this annotation

GitHub Actions / lint 

empty-lines: extra empty line at the start of a block (revive)
t.Parallel()

db, _ := dbtestutil.NewDB(t)
manager := runtimeconfig.NewManager()
Expand Down
Loading