fix: handle null value for experiments #17584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 1 commit into main from bq/fix-null-experiments

Apr 28, 2025

Collaborator

BrunoQuaresma commented Apr 28, 2025

Relevant info

option.value can be null
It is always better to use unknown instead of any, and use type assertion functions as Array.isArray() before using/accessing object properties and functions


          fix: handle null value for experiments

55ee15f

BrunoQuaresma self-assigned this

BrunoQuaresma requested review from Emyrk, a team and code-asher and removed request for a team

April 28, 2025 14:04

Parkreiner approved these changes

View reviewed changes

Member

Parkreiner left a comment

Changes look straightforward to me! I think some of the anys were when we were rushing through the original GUTS migration

BrunoQuaresma merged commit 5ca90ae into main

36 checks passed

BrunoQuaresma deleted the bq/fix-null-experiments branch

April 28, 2025 14:12

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet