chore: remove circular dependencies #17585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
Apr 28, 2025
site/src/hooks/index.ts
Outdated
| @@ -2,3 +2,4 @@ export * from "./useClickable"; | |||
| export * from "./useClickableTableRow"; | |||
| export * from "./useClipboard"; | |||
| export * from "./usePagination"; | |||
| export * from "./useAuthenticated"; | |||
There was a problem hiding this comment.
this context needs to stay colocated where it was so that we actually remember to delete it when the feature is done
aslilac
approved these changes
Apr 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been bit in the past by hard to deduce bugs caused by circular dependencies within TS projects. On a hunch that this could be contributing to some flaky tests I've used the tool dpdm to find and remove them.
This PR does the following:
check:circular-depencypnpm script