coder · brettkolodny · Apr 30, 2025 · Apr 29, 2025 · Apr 29, 2025 · Apr 29, 2025
diff --git a/site/.knip.jsonc b/site/.knip.jsonc
@@ -0,0 +1,17 @@
+{
+	"$schema": "https://unpkg.com/knip@5/schema.json",
+	"entry": ["./src/index.tsx", "./src/serviceWorker.ts"],
+	"project": ["./src/**/*.ts", "./src/**/*.tsx", "./e2e/**/*.ts"],
+	"ignore": ["**/*Generated.ts"],
+	"ignoreBinaries": ["protoc"],
+	"ignoreDependencies": [
+		"@types/react-virtualized-auto-sizer",
+		"jest_workaround",
+		"ts-proto"
+	],
+	// Don't report unused exports of types as long as they are used within the file.
+	"ignoreExportsUsedInFile": {
+		"interface": true,
+		"type": true
+	}
+}
diff --git a/site/biome.jsonc b/site/biome.jsonc
@@ -16,6 +16,9 @@
 				"useButtonType": { "level": "off" },
 				"useSemanticElements": { "level": "off" }
 			},
+			"correctness": {
+				"noUnusedImports": "warn"
+			},
 			"style": {
 				"noNonNullAssertion": { "level": "off" },
 				"noParameterAssign": { "level": "off" },

diff --git a/site/e2e/constants.ts b/site/e2e/constants.ts
@@ -78,14 +78,6 @@ export const premiumTestsRequired = Boolean(
 
 export const license = process.env.CODER_E2E_LICENSE ?? "";
 
-/**
- * Certain parts of the UI change when organizations are enabled. Organizations
- * are enabled by a license entitlement, and license configuration is guaranteed
- * to run before any other tests, so having this as a bit of "global state" is
- * fine.
- */
-export const organizationsEnabled = Boolean(license);
-
 // Disabling terraform tests is optional for environments without Docker + Terraform.
 // By default, we opt into these tests.
 export const requireTerraformTests = !process.env.CODER_E2E_DISABLE_TERRAFORM;

diff --git a/site/e2e/helpers.ts b/site/e2e/helpers.ts
@@ -81,7 +81,7 @@ export async function login(page: Page, options: LoginOptions = users.owner) {
 	(ctx as any)[Symbol.for("currentUser")] = options;
 }
 
-export function currentUser(page: Page): LoginOptions {
+function currentUser(page: Page): LoginOptions {
 	const ctx = page.context();
 	// biome-ignore lint/suspicious/noExplicitAny: get the current user
 	const user = (ctx as any)[Symbol.for("currentUser")];
@@ -875,7 +875,7 @@ export const echoResponsesWithExternalAuth = (
 	};
 };
 
-export const fillParameters = async (
+const fillParameters = async (
 	page: Page,
 	richParameters: RichParameter[] = [],
 	buildParameters: WorkspaceBuildParameter[] = [],

diff --git a/site/e2e/tests/deployment/idpOrgSync.spec.ts b/site/e2e/tests/deployment/idpOrgSync.spec.ts
@@ -5,7 +5,6 @@ import {
 	deleteOrganization,
 	setupApiCalls,
 } from "../../api";
-import { users } from "../../constants";
 import { login, randomName, requiresLicense } from "../../helpers";
 import { beforeCoderTest } from "../../hooks";
 

diff --git a/site/e2e/tests/organizations/auditLogs.spec.ts b/site/e2e/tests/organizations/auditLogs.spec.ts
@@ -1,4 +1,4 @@
-import { type Page, expect, test } from "@playwright/test";
+import { expect, test } from "@playwright/test";
 import {
 	createOrganization,
 	createOrganizationMember,

diff --git a/site/package.json b/site/package.json
@@ -13,10 +13,11 @@
 		"dev": "vite",
 		"format": "biome format --write .",
 		"format:check": "biome format .",
-		"lint": "pnpm run lint:check && pnpm run lint:types && pnpm run lint:circular-deps",
+		"lint": "pnpm run lint:check && pnpm run lint:types && pnpm run lint:circular-deps && knip",
 		"lint:check": " biome lint --error-on-warnings .",
 		"lint:circular-deps": "dpdm --no-tree --no-warning -T ./src/App.tsx",
-		"lint:fix": " biome lint --error-on-warnings --write .",
+		"lint:knip": "knip",
+		"lint:fix": " biome lint --error-on-warnings --write . && knip --fix",
 		"lint:types": "tsc -p .",
 		"playwright:install": "playwright install --with-deps chromium",
 		"playwright:test": "playwright test --config=e2e/playwright.config.ts",
@@ -29,7 +30,6 @@
 		"test:ci": "jest --selectProjects test --silent",
 		"test:coverage": "jest --selectProjects test --collectCoverage",
 		"test:watch": "jest --selectProjects test --watch",
-		"test:storybook": "test-storybook",
 		"stats": "STATS=true pnpm build && npx http-server ./stats -p 8081 -c-1",
 		"deadcode": "ts-prune | grep -v \".stories\\|.config\\|e2e\\|__mocks__\\|used in module\\|testHelpers\\|typesGenerated\" || echo \"No deadcode found.\"",
 		"update-emojis": "cp -rf ./node_modules/emoji-datasource-apple/img/apple/64/* ./static/emojis"
@@ -68,7 +68,6 @@
 		"@radix-ui/react-slot": "1.1.1",
 		"@radix-ui/react-switch": "1.1.1",
 		"@radix-ui/react-tooltip": "1.1.7",
-		"@radix-ui/react-visually-hidden": "1.1.0",
 		"@tanstack/react-query-devtools": "4.35.3",
 		"@xterm/addon-canvas": "0.7.0",
 		"@xterm/addon-fit": "0.10.0",
@@ -78,10 +77,8 @@
 		"@xterm/xterm": "5.5.0",
 		"ansi-to-html": "0.7.2",
 		"axios": "1.8.2",
-		"canvas": "3.1.0",
 		"chart.js": "4.4.0",
 		"chartjs-adapter-date-fns": "3.0.0",
-		"chartjs-plugin-annotation": "3.0.1",
 		"chroma-js": "2.4.2",
 		"class-variance-authority": "0.7.1",
 		"clsx": "2.1.1",
@@ -91,7 +88,6 @@
 		"cronstrue": "2.50.0",
 		"date-fns": "2.30.0",
 		"dayjs": "1.11.13",
-		"emoji-datasource-apple": "15.1.2",
 		"emoji-mart": "5.6.0",
 		"file-saver": "2.0.5",
 		"formik": "2.4.6",
@@ -149,7 +145,6 @@
 		"@tailwindcss/typography": "0.5.16",
 		"@testing-library/jest-dom": "6.6.3",
 		"@testing-library/react": "14.3.1",
-		"@testing-library/react-hooks": "8.0.1",
 		"@testing-library/user-event": "14.6.1",
 		"@types/chroma-js": "2.4.0",
 		"@types/color-convert": "2.0.4",
@@ -181,16 +176,15 @@
 		"jest-location-mock": "2.0.0",
 		"jest-websocket-mock": "2.5.0",
 		"jest_workaround": "0.1.14",
+		"knip": "5.51.0",
 		"msw": "2.4.8",
 		"postcss": "8.5.1",
 		"protobufjs": "7.4.0",
 		"rxjs": "7.8.1",
 		"ssh2": "1.16.0",
 		"storybook": "8.5.3",
 		"storybook-addon-remix-react-router": "3.1.0",
-		"storybook-react-context": "0.7.0",
 		"tailwindcss": "3.4.17",
-		"ts-node": "10.9.2",
 		"ts-proto": "1.164.0",
 		"ts-prune": "0.10.3",
 		"typescript": "5.6.3",