fix: update default value handling for dynamic defaults #17609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
May 1, 2025
Comment on lines
+208
to
+215
| const selectedOptions: Option[] = JSON.parse(value).map((val: string) => { | ||
| const option = parameter.options.find((o) => o.value.value === val); | ||
| return { | ||
| value: val, | ||
| label: option?.name || val, | ||
| disable: false, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
this is screaming for some sort of typing issue here. how confident are we that JSON.parse(value) will actually always return a string[] here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves coder/preview#102