Skip to content

test: avoid sharing echo.Responses across tests #17610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

test: avoid sharing echo.Responses across tests #17610

merged 1 commit into from
Apr 30, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Apr 30, 2025 •
edited
Loading

I missed this in #17211 because I only searched for := &echo.Responses and not = &echo.Responses 🤦

Fixes flakes like https://github.com/coder/coder/actions/runs/14746732612/job/41395403979

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson added the hotfix PRs only. Harmless small change. Only humans may set this. label Apr 30, 2025
@ethanndickson ethanndickson marked this pull request as ready for review April 30, 2025 05:05
cdr-bot[bot]
cdr-bot bot approved these changes Apr 30, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson enabled auto-merge (squash) April 30, 2025 05:05
@ethanndickson ethanndickson merged commit 7a1e56b into main Apr 30, 2025
43 checks passed
@ethanndickson ethanndickson deleted the ethan/fix-echo-race branch April 30, 2025 05:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@ethanndickson ethanndickson

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanndickson