Skip to content

fix(dogfood/coder): increase in-container docker daemon shutdown timeout #17617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Apr 30, 2025

The default is 10 seconds and will not successfully clean up large
devcontainers inside the workspace.

Follow-up to #17528

The default is 10 seconds and will not successfully clean up large
devcontainers inside the workspace.
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing this has been smoke-tested, looks good to me :shipit:

@mafredri
Copy link
Member Author

@DanielleMaywood Yep, tried it out in the https://dev.coder.com/templates/coder/maf-devcontainers template 🚀

@mafredri mafredri merged commit fe4c412 into main Apr 30, 2025
38 checks passed
@mafredri mafredri deleted the mafredri/fix-dogfood-devcontainer-cleanup branch April 30, 2025 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants