refactor: change how timings are formatted #17623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how timing values are formatted in the WorkspaceTiming module by replacing the multiple unit decomposition with a simplified conditional format based on thresholds.
- Refactored the formatTime function for clearer unit conversion.
- Updated the calculation of formatted time using a single value and unit based on predefined thresholds.
Comment on lines
+69
to
+84
| value = time; | ||
| unit = "ms"; | ||
| } else if (absTime < minute) { | ||
| value = time / second; | ||
| unit = "s"; | ||
| } else if (absTime < hour) { | ||
| value = time / minute; | ||
| unit = "m"; | ||
| } else if (absTime < day) { | ||
| value = time / hour; | ||
| unit = "h"; | ||
| } else { | ||
| value = time / day; | ||
| unit = "d"; | ||
| } | ||
| if (hours > 0) { | ||
| parts.push(`${hours % 24}h`); | ||
| } | ||
| if (minutes > 0) { | ||
| parts.push(`${minutes % 60}m`); | ||
| } | ||
| if (seconds > 0) { | ||
| parts.push(`${seconds % 60}s`); | ||
| } | ||
| if (time % 1000 > 0) { | ||
| parts.push(`${time % 1000}ms`); | ||
| } | ||
|
|
||
| return parts.join(" "); | ||
| return `${value.toLocaleString(undefined, { |
There was a problem hiding this comment.
Using 'absTime' for the threshold comparisons but assigning the unmodified 'time' for the value may lead to inconsistent formatting for negative inputs. Consider using 'absTime' for the conversion calculation or explicitly handling negative values.
Copilot uses AI. Check for mistakes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.