feat: add inline actions into workspaces table #17636
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces inline actions to the workspaces table while refactoring how workspace data is queried and updated. Key changes include:
- Refactoring the useWorkspacesData hook to accept a WorkspacesRequest object and updating query keys.
- Implementing a new WorkspaceActionsCell with inline action buttons and associated success/error callbacks.
- Removing redundant isOwner props by computing ownership via the authenticated user, and updating related update/cancellation hooks.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| site/src/pages/WorkspacesPage/data.ts | Refactors workspace data fetching to use WorkspacesRequest and updates the queryKey handling. |
| site/src/pages/WorkspacesPage/WorkspacesTable.tsx | Introduces the WorkspaceActionsCell component and updates table cell layout. |
| site/src/pages/WorkspacesPage/WorkspacesPageView.tsx | Passes inline action callbacks to the table component. |
| site/src/pages/WorkspacesPage/WorkspacesPage.tsx | Updates query parameter naming and adds action success/error callbacks. |
| site/src/pages/WorkspacePage/WorkspaceTopbar.tsx | Removes the isOwner prop; ownership is now derived via authentication. |
| site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx | Switches to the new workspace update hook and renders WorkspaceUpdateDialogs. |
| site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx | Refactors cancel button logic by computing isOwner locally and replacing the showCancel variable. |
| site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx | Adds an auth provider for story consistency. |
| site/src/modules/workspaces/useWorkspaceUpdate.tsx | Implements a new hook for workspace update flows with confirmation/missing parameter dialogs. |
| site/src/modules/workspaces/actions.ts | Adjusts abilities logic to take a permissions object instead of a boolean for canDebug. |
| site/src/hooks/usePagination.ts | Replaces manual offset calculation with the calcOffset helper function. |
| site/src/components/Dialogs/Dialog.tsx | Adds stopPropagation logic to cancel button clicks to avoid undesired events. |
| site/src/api/queries/workspaces.ts | Updates queryFn to pass full request config to the API. |
Comments suppressed due to low confidence (2)
site/src/pages/WorkspacePage/WorkspaceTopbar.tsx:55
- [nitpick] Since the isOwner prop is removed and ownership is now derived from the authenticated user, ensure that all child components relying on 'isOwner' are updated accordingly to prevent any unexpected UI behavior.
// Removed: isOwner prop
site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx:174
- [nitpick] Replacing the 'showCancel' condition with 'canCancel' changes the criteria for displaying the CancelButton; please verify that this aligns with the intended cancellation permissions and workspace state logic.
{canCancel && <CancelButton handleAction={handleCancel} />}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.