Skip to content

fix: get checkbox label from dynamic parameter styling prop #17651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: get checkbox label from dynamic parameter styling prop #17651

wants to merge 1 commit into from
+1 −1

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented May 1, 2025 •
edited
Loading

resolves #17474

A label will only be shown next to the checkbox If there is a value for label in the styling prop for the dynamic parameter

Screenshot 2025-05-01 at 21 35 32

@jaaydenh jaaydenh self-assigned this May 1, 2025
@jaaydenh jaaydenh requested a review from aslilac May 1, 2025 20:35
aslilac
aslilac reviewed May 1, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix whatever the type of parameter.styling is here. even if it's just Record<string, string>, that's better than one off type assertions littered all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslilac aslilac aslilac left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parameters: how can/should we support a different checkbox value from the title
2 participants
@jaaydenh @aslilac