Skip to content

fix: fix bug with deletion of prebuilt workspaces #17652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbina evgeniy-scherbina commented May 1, 2025

Don't specify the template version for a delete transition, because the prebuilt workspace may have been created using an older template version.
If the template version isn't explicitly set, the builder will automatically use the version from the last workspace build - which is the desired behavior.

@evgeniy-scherbina evgeniy-scherbina force-pushed the yevhenii/prebuilds-minor-fix branch from 549aea5 to 2795b72 Compare May 1, 2025 20:56
@evgeniy-scherbina evgeniy-scherbina changed the title fix: bug with deletion of prebuilt workspaces fix: fix bug with deletion of prebuilt workspaces May 1, 2025
@evgeniy-scherbina evgeniy-scherbina marked this pull request as ready for review May 1, 2025 21:11
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please add a short description to help folks without context.

@evgeniy-scherbina evgeniy-scherbina merged commit ef11d4f into main May 1, 2025
40 checks passed
@evgeniy-scherbina evgeniy-scherbina deleted the yevhenii/prebuilds-minor-fix branch May 1, 2025 21:26
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants