Skip to content

fix: fix windsurf icon on light theme (cherry-pick #17679) #17686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

fix: fix windsurf icon on light theme (cherry-pick #17679) #17686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion site/src/modules/resources/AppLink/BaseIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import ComputerIcon from "@mui/icons-material/Computer";
import type { WorkspaceApp } from "api/typesGenerated";
import { ExternalImage } from "components/ExternalImage/ExternalImage";
import type { FC } from "react";

interface BaseIconProps {
Expand All @@ -9,7 +10,7 @@ interface BaseIconProps {

export const BaseIcon: FC<BaseIconProps> = ({ app, onIconPathError }) => {
return app.icon ? (
<img
<ExternalImage
alt={`${app.display_name} Icon`}
src={app.icon}
style={{ pointerEvents: "none" }}
Expand Down
1 change: 1 addition & 0 deletions site/src/theme/externalImages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,5 @@ export const defaultParametersForBuiltinIcons = new Map<string, string>([
["/icon/rust.svg", "monochrome"],
["/icon/terminal.svg", "monochrome"],
["/icon/widgets.svg", "monochrome"],
["/icon/windsurf.svg", "monochrome"],
]);
Loading