Skip to content

chore: pass previous values into terraform apply #17696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 12, 2025
Merged

chore: pass previous values into terraform apply #17696

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d565cb5
chore: pass previous values into the terraform apply
Emyrk May 6, 2025
b6d3d67
update preview
Emyrk May 7, 2025
520fe49
make gen
Emyrk May 7, 2025
690daac
test: fix asserted test error text
Emyrk May 7, 2025
692bab8
remove from plan request
Emyrk May 7, 2025
81ad901
remove previous values from plan
Emyrk May 7, 2025
c917ab0
remove from plan request
Emyrk May 7, 2025
28b2b9f
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 9, 2025
3fb8a22
reset go.mod
Emyrk May 9, 2025
2b642a6
update preview
Emyrk May 9, 2025
fd6cdf5
update versions
Emyrk May 9, 2025
2b41b8f
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 12, 2025
8a0dab1
chore: add previous values to plan request
Emyrk May 12, 2025
d9fc4cc
make gen
Emyrk May 12, 2025
fb2f081
pass in previous values to the plan step
Emyrk May 12, 2025
97a99aa
pass previous values in workspace build
Emyrk May 12, 2025
9f3a8fd
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 12, 2025
bc38bfa
revert go mod changes
Emyrk May 12, 2025
a7ab88c
make gen
Emyrk May 12, 2025
52dcd80
Merge branch 'main' into stevenmasley/monotonic
Emyrk May 12, 2025
3eb22f4
Merge remote-tracking branch 'origin/main' into stevenmasley/monotonic
Emyrk May 12, 2025
cb0f145
gen
Emyrk May 12, 2025
2774c07
make gen
Emyrk May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pass previous values in workspace build
  • Loading branch information
@Emyrk
Emyrk committed May 12, 2025
commit 97a99aa136616ec9da362a533c4baab71e64c719
13 changes: 8 additions & 5 deletions provisionerd/runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,9 @@ func (r *Runner) runTemplateImportProvisionWithRichParameters(
err := r.session.Send(&sdkproto.Request{Type: &sdkproto.Request_Plan{Plan: &sdkproto.PlanRequest{
Metadata: metadata,
RichParameterValues: richParameterValues,
VariableValues: variableValues,
// Template import has no previous values
PreviousParameterValues: make([]*sdkproto.RichParameterValue, 0),
VariableValues: variableValues,
}}})
if err != nil {
return nil, xerrors.Errorf("start provision: %w", err)
Expand Down Expand Up @@ -957,10 +959,11 @@ func (r *Runner) runWorkspaceBuild(ctx context.Context) (*proto.CompletedJob, *p
resp, failed := r.buildWorkspace(ctx, "Planning infrastructure", &sdkproto.Request{
Type: &sdkproto.Request_Plan{
Plan: &sdkproto.PlanRequest{
Metadata: r.job.GetWorkspaceBuild().Metadata,
RichParameterValues: r.job.GetWorkspaceBuild().RichParameterValues,
VariableValues: r.job.GetWorkspaceBuild().VariableValues,
ExternalAuthProviders: r.job.GetWorkspaceBuild().ExternalAuthProviders,
Metadata: r.job.GetWorkspaceBuild().Metadata,
RichParameterValues: r.job.GetWorkspaceBuild().RichParameterValues,
PreviousParameterValues: r.job.GetWorkspaceBuild().PreviousParameterValues,
VariableValues: r.job.GetWorkspaceBuild().VariableValues,
ExternalAuthProviders: r.job.GetWorkspaceBuild().ExternalAuthProviders,
},
},
})
Expand Down