Skip to content

Add coder executable to PATH #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 26, 2022
Merged

Add coder executable to PATH #1771

merged 7 commits into from
May 26, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented May 26, 2022

Closes #1767

@f0ssel f0ssel marked this pull request as ready for review May 26, 2022 01:48
@f0ssel f0ssel requested a review from kylecarbs May 26, 2022 01:50
@f0ssel f0ssel force-pushed the f0ssel/coder-path branch from 72f08dd to d18422e Compare May 26, 2022 01:51
@AbhineetJain
Copy link
Contributor

AbhineetJain commented May 26, 2022 •
edited
Loading

I wonder if the PATH env variable also works for Windows. Found that it does. Is there a way we can test this functionality?

kylecarbs
kylecarbs approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that we're appending it to the path because that means it's the lowest priority. That would allow users to have a higher-priority Coder binary in the path without a problem.

It'd be helpful to add a comment explaining that. It could cause unexpected behavior if a user overrides it, but it's better than having a hard-to-override default.

@jsjoeio
Copy link
Contributor

jsjoeio commented May 26, 2022

It's good that we're appending it to the path because that means it's the lowest priority. That would allow users to have a higher-priority Coder binary in the path without a problem.

non-blocking: should we add a test for that? i.e. user already has previous coder binary or coder v1 binary in path

@f0ssel f0ssel merged commit 3052a6d into main May 26, 2022
@f0ssel f0ssel deleted the f0ssel/coder-path branch May 26, 2022 17:59
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@f0ssel @kylecarbs
Add coder executable to PATH (#1771)
c1d1e1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@AbhineetJain AbhineetJain AbhineetJain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: coder binary not in path
4 participants
@f0ssel @AbhineetJain @jsjoeio @kylecarbs