Skip to content

fix(agent): fix unexpanded devcontainer paths for agentcontainers #17736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2025
Merged

fix(agent): fix unexpanded devcontainer paths for agentcontainers #17736

merged 4 commits into from
May 12, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented May 9, 2025 •
edited
Loading

I noticed devcontainers were duplicated in the API because paths weren't absolute, so now we normalize them early on to keep it simple.

Updates #16424

@mafredri mafredri requested a review from DanielleMaywood May 9, 2025 09:38
DanielleMaywood
DanielleMaywood approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe we could have an extra test so we don't have a regression of this in the future

@mafredri mafredri force-pushed the mafredri/fix-agent-agentcontainers-expandpath-bug branch from edc0731 to 9753283 Compare May 9, 2025 11:34
@mafredri
Copy link
Member Author

mafredri commented May 9, 2025

Looks good to me! Maybe we could have an extra test so we don't have a regression of this in the future

Good idea, updated the existing test to require expansion 👍🏻. It does rely on precedence of operations in expandPathToAbs (e.g. $HOME before /etc/passwd) which may be a bit brittle, but if that functionality changes we may have other problems too 😄.

@mafredri mafredri merged commit 7af188b into main May 12, 2025
34 checks passed
@mafredri mafredri deleted the mafredri/fix-agent-agentcontainers-expandpath-bug branch May 12, 2025 11:03
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @DanielleMaywood