• chore: apply the 4mb max limit on drpc protocol message size #17771 👈 (View in Graphite)
• chore: resolve internal drpc package conflict #17770
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

I'm not sure I follow the logic. Aren't modules fetched dynamically at import time, which happens after the (up to) 10MB upload? There are no constraints on how big the modules could be during the import build which downloads them from a registry.

I'm not sure I follow the logic. Aren't modules fetched dynamically at import time, which happens after the (up to) 10MB upload? There are no constraints on how big the modules could be during the import build which downloads them from a registry.

You are right, modules will have to have a different solution.

I thought a 10mb file could be uploaded as a template version, which would fail at the protobuf layer. Our cli prevents this though, at a 1mb limit. So I will remove the bump to 10mb.

We should still keep the config setting, as we check against 4mb limits here:

Edit: Reverted to 4mb, but still want the constant to set the settings