Skip to content

feat: add extra workspace actions in the workspaces table #17775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 13, 2025
Merged

feat: add extra workspace actions in the workspaces table #17775

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
496473f
Refactor base menu component
BrunoQuaresma May 12, 2025
22759e3
Refactor change workspace version
BrunoQuaresma May 12, 2025
2f3cce0
Refactor delete workspace
BrunoQuaresma May 12, 2025
f7e9ba9
Refactor duplicate and clean up code
BrunoQuaresma May 12, 2025
a3c4908
Move components and fix build errors
BrunoQuaresma May 12, 2025
d5ae7e1
Minor visual fixes
BrunoQuaresma May 12, 2025
0c65d4f
Fix debug check
BrunoQuaresma May 12, 2025
3b5f20b
Add more actions to workspaces row
BrunoQuaresma May 12, 2025
207094a
Minor fixes
BrunoQuaresma May 12, 2025
c79952b
Run FMT
BrunoQuaresma May 12, 2025
be967dd
Fix lint and tests
BrunoQuaresma May 12, 2025
139548c
Fix stories
BrunoQuaresma May 13, 2025
84b65a8
Apply PR reviews
BrunoQuaresma May 13, 2025
96a6ffd
Merge branch 'main' of https://github.com/coder/coder into bq/more-ac…
BrunoQuaresma May 13, 2025
62413e0
Fix stories
BrunoQuaresma May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint and tests
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 12, 2025
commit be967dd75c7e0043d0961308a083c8d369a7dfbe
5 changes: 0 additions & 5 deletions site/src/pages/WorkspacePage/WorkspaceTopbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ import { WorkspaceActions } from "./WorkspaceActions/WorkspaceActions";
import { WorkspaceNotifications } from "./WorkspaceNotifications/WorkspaceNotifications";
import { WorkspaceScheduleControls } from "./WorkspaceScheduleControls";

export type WorkspaceError =
| "getBuildsError"
| "buildError"
| "cancellationError";

export interface WorkspaceProps {
isUpdating: boolean;
isRestarting: boolean;
Expand Down
14 changes: 7 additions & 7 deletions site/src/pages/WorkspacesPage/WorkspacesPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ describe("WorkspacesPage", () => {
await user.click(getWorkspaceCheckbox(workspaces[0]));
await user.click(getWorkspaceCheckbox(workspaces[1]));

await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const deleteButton = await screen.findByText(/delete/i);
await user.click(deleteButton);

Expand Down Expand Up @@ -106,7 +106,7 @@ describe("WorkspacesPage", () => {
await user.click(getWorkspaceCheckbox(workspace));
}

await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const updateButton = await screen.findByText(/update/i);
await user.click(updateButton);

Expand Down Expand Up @@ -145,7 +145,7 @@ describe("WorkspacesPage", () => {
await user.click(getWorkspaceCheckbox(workspace));
}

await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const updateButton = await screen.findByText(/update/i);
await user.click(updateButton);

Expand Down Expand Up @@ -183,7 +183,7 @@ describe("WorkspacesPage", () => {
await user.click(getWorkspaceCheckbox(workspace));
}

await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const updateButton = await screen.findByText(/update/i);
await user.click(updateButton);

Expand Down Expand Up @@ -223,7 +223,7 @@ describe("WorkspacesPage", () => {
await user.click(getWorkspaceCheckbox(workspace));
}

await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const updateButton = await screen.findByText(/update/i);
await user.click(updateButton);

Expand Down Expand Up @@ -263,7 +263,7 @@ describe("WorkspacesPage", () => {

await user.click(getWorkspaceCheckbox(workspaces[0]));
await user.click(getWorkspaceCheckbox(workspaces[1]));
await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const stopButton = await screen.findByRole("menuitem", { name: /stop/i });
await user.click(stopButton);

Expand All @@ -290,7 +290,7 @@ describe("WorkspacesPage", () => {

await user.click(getWorkspaceCheckbox(workspaces[0]));
await user.click(getWorkspaceCheckbox(workspaces[1]));
await user.click(screen.getByRole("button", { name: /actions/i }));
await user.click(screen.getByRole("button", { name: /bulk actions/i }));
const startButton = await screen.findByRole("menuitem", { name: /start/i });
await user.click(startButton);

Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/WorkspacesPage/WorkspacesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export const WorkspacesPageView: FC<WorkspacesPageViewProps> = ({
css={{ borderRadius: 9999, marginLeft: "auto" }}
endIcon={<ChevronDownIcon className="size-4" />}
>
Actions
Bulk actions
</LoadingButton>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
Expand Down
Loading