Skip to content

chore: replace MUI icons with Lucide icons - 7 #17776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

chore: replace MUI icons with Lucide icons - 7 #17776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e536d10
chore: replace MUI icons with Lucide icons - 7
BrunoQuaresma May 12, 2025
d3415ec
FMT
BrunoQuaresma May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions site/src/modules/resources/SensitiveValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { type Interpolation, type Theme, css } from "@emotion/react";
import VisibilityOffOutlined from "@mui/icons-material/VisibilityOffOutlined";
import VisibilityOutlined from "@mui/icons-material/VisibilityOutlined";
import IconButton from "@mui/material/IconButton";
import Tooltip from "@mui/material/Tooltip";
import { CopyableValue } from "components/CopyableValue/CopyableValue";
import { EyeIcon, EyeOffIcon } from "lucide-react";
import { type FC, useState } from "react";

const Language = {
Expand All @@ -20,9 +19,9 @@ export const SensitiveValue: FC<SensitiveValueProps> = ({ value }) => {
const displayValue = shouldDisplay ? value : "••••••••";
const buttonLabel = shouldDisplay ? Language.hideLabel : Language.showLabel;
const icon = shouldDisplay ? (
<VisibilityOffOutlined />
<EyeOffIcon className="size-icon-xs" />
) : (
<VisibilityOutlined />
<EyeIcon className="size-icon-xs" />
);

return (
Expand Down Expand Up @@ -63,10 +62,5 @@ const styles = {

button: css`
color: inherit;

& .MuiSvgIcon-root {
width: 16px;
height: 16px;
}
`,
} satisfies Record<string, Interpolation<Theme>>;
7 changes: 3 additions & 4 deletions site/src/pages/OrganizationSettingsPage/CustomRolesPage/CreateEditRolePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import type { Interpolation, Theme } from "@emotion/react";
import VisibilityOffOutlinedIcon from "@mui/icons-material/VisibilityOffOutlined";
import VisibilityOutlinedIcon from "@mui/icons-material/VisibilityOutlined";
import Checkbox from "@mui/material/Checkbox";
import FormControlLabel from "@mui/material/FormControlLabel";
import Table from "@mui/material/Table";
Expand Down Expand Up @@ -32,6 +30,7 @@ import {
import { Spinner } from "components/Spinner/Spinner";
import { Stack } from "components/Stack/Stack";
import { useFormik } from "formik";
import { EyeIcon, EyeOffIcon } from "lucide-react";
import { type ChangeEvent, type FC, useState } from "react";
import { useNavigate } from "react-router-dom";
import { getFormHelpers, nameValidator } from "utils/formUtils";
Expand Down Expand Up @@ -398,8 +397,8 @@ const ShowAllResourcesCheckbox: FC<ShowAllResourcesCheckboxProps> = ({
name="show_all_permissions"
checked={showAllResources}
onChange={(e) => setShowAllResources(e.currentTarget.checked)}
checkedIcon={<VisibilityOutlinedIcon />}
icon={<VisibilityOffOutlinedIcon />}
checkedIcon={<EyeIcon className="size-icon-sm" />}
icon={<EyeOffIcon className="size-icon-sm" />}
/>
}
label={
Expand Down
Loading