Skip to content

feat: add one shot commands to the coder ssh command #17779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 16, 2025
Merged

feat: add one shot commands to the coder ssh command #17779

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
594e4b5
feat: allow one shot commands using coder ssh
brettkolodny May 12, 2025
bed4103
chore: improve ssh missing args error message
brettkolodny May 12, 2025
4026c07
fix: lint
brettkolodny May 12, 2025
55735fc
fix: gen
brettkolodny May 12, 2025
aaaab01
fix: update command to work on both unix and windows
brettkolodny May 13, 2025
d4feb6c
Merge branch 'main' into bett-feat/add-ssh-one-shot-command
brettkolodny May 13, 2025
19fa5f9
Merge branch 'main' into bett-feat/add-ssh-one-shot-command
brettkolodny May 14, 2025
c25d27f
Merge branch 'main' into bett-feat/add-ssh-one-shot-command
brettkolodny May 15, 2025
ca640b5
chore: add example to ssh help documentation
brettkolodny May 16, 2025
e0a3e7a
chore: make gen
brettkolodny May 16, 2025
bfd941d
Merge branch 'main' into bett-feat/add-ssh-one-shot-command
brettkolodny May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: lint
  • Loading branch information
@brettkolodny
brettkolodny committed May 12, 2025
commit 4026c077dd4016d03e4ff16bd1999eda70151045
1 change: 0 additions & 1 deletion cli/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,6 @@ func (r *RootCmd) ssh() *serpent.Command {
}
return xerrors.Errorf("session ended: %w", err)
}

}
return nil
},
Expand Down
3 changes: 1 addition & 2 deletions cli/ssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
"golang.org/x/crypto/ssh"
gossh "golang.org/x/crypto/ssh"
gosshagent "golang.org/x/crypto/ssh/agent"
"golang.org/x/sync/errgroup"
"golang.org/x/xerrors"
Expand Down Expand Up @@ -2258,7 +2257,7 @@ func TestSSH_CoderConnect(t *testing.T) {

err := inv.WithContext(ctx).Run()
assert.Error(t, err)
var exitErr *gossh.ExitError
var exitErr *ssh.ExitError
assert.True(t, errors.As(err, &exitErr))
assert.Equal(t, 1, exitErr.ExitStatus())
})
Expand Down
Loading